Make tests depend on environment variables for classpath jars #1738
Conversation
| private val dottyLibrary = | ||
| new java.io.File("../library/target/scala-2.11/dotty-library_2.11-0.1-SNAPSHOT.jar").getPath | ||
| new java.io.File(Jars.dottyLib).getPath |
There was a problem hiding this comment.
Note that the whole point of this test and InterfaceEntryPointsTest is to give an example of how to use the compilers entry points for external projects; so relying on extra files and/or hardcoded path is not great.
There was a problem hiding this comment.
Sure, but do you have an alternative?
| @@ -15,6 +15,7 @@ object DottyBuild extends Build { | |||
| val isNightly = sys.env.get("NIGHTLYBUILD") == Some("yes") | |||
|
|
|||
| val jenkinsMemLimit = List("-Xmx1500m") | |||
| val ciLimitedThreads = List("-Ddotty.tests.limitedThreads=2") | |||
There was a problem hiding this comment.
Is this necessary if this is the default?
| * in `project/Build.scala`. | ||
| */ | ||
| def limitResourceFlags = List("-Ytest-pickler") | ||
| private val limitedThreads = sys.props.get("dotty.tests.limitedThreads").getOrElse("2") |
There was a problem hiding this comment.
You should make sure that limitedThreads is always less than or equal to partest.threads
|
|
||
| NestUI.echo(s"## we will run ${sequentialTests.length} tests using ${PartestDefaults.numThreads} thread(s)") | ||
| val res = super.runTestsForFiles(sequentialTests, kind) | ||
| NestUI.echo(s"## we will run ${limitResourceTests.length} tests using ${PartestDefaults.numThreads} thread(s)") |
There was a problem hiding this comment.
This message is slightly different from the message below, either add in parallel here or remove it below
felixmulder
force-pushed
the
topic/environmentally-friendly-tests
branch
2 times, most recently
from
e05afde to
2f839d2
Compare
sbt adds the correct jars to classpath and the tests depend on `packageAll` which creates these. When using something else however, these together with `sbt-interfaces` do not get propagated from the build. To remedy this and make the testing a bit more flexible, we now take these from `sys.props` instead, see `tests/dotty/Jars.scala`. If the props aren't defined we fall back to the ones default to sbt.
felixmulder
force-pushed
the
topic/environmentally-friendly-tests
branch
from
2f839d2 to
ede2d53
Compare
|
Superseded by #1739 sot that Martin can add his fixes for Eclipse |
sbt adds the correct jars to classpath and the tests depend on
packageAllwhich creates these. When using something else, however,these together with
sbt-interfacesdo not get propagated from thebuild.
To remedy this and make the testing a bit more flexible, we now
take these from
sys.propsinstead, seetests/dotty/Jars.scala.If the props aren't defined we fall back to the ones default to sbt.
review by: @odersky